Skip to content

TST: coverage for skipped tests in io/formats/test_to_html.py #22888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 7, 2018
Merged

TST: coverage for skipped tests in io/formats/test_to_html.py #22888

merged 5 commits into from
Nov 7, 2018

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Sep 29, 2018 •
edited
Loading

There are currently 3 skipped tests in io/formats/test_to_html.py; test_to_html_truncate, test_to_html_truncate_multi_index and test_to_html_truncate_multi_index_sparse_off

Only test_to_html_truncate is required to provide regression coverage for #22786

However, it is probably appropriate for any changes to test_to_html_truncate to also be applied to the other two skipped tests within the scope of this PR.

cc @jreback

@pep8speaks
Copy link

Hello @simonjayhawkins! Thanks for submitting the PR.

@simonjayhawkins
Copy link
Member Author

test_to_html_truncate_multi_index_sparse_off should fail! see #22887

@simonjayhawkins
Copy link
Member Author

changing:

pandas/pandas/io/formats/html.py

Line 235 in e45a6c1

sentinel = None

to:

sentinel = False

would pass all tests.

@simonjayhawkins
Copy link
Member Author

I have reduced the scope of the skipped tests to the truncation part and removed the _repr_html_ path.

there are other tests that check that the style is applied.

@jreback jreback added Testing pandas testing functions or related to the test suite IO HTML read_html, to_html, Styler.apply, Styler.applymap labels Oct 1, 2018
@jreback
Copy link
Contributor

jreback commented Oct 1, 2018

can you rebase / tests are failng

@codecov
Copy link

codecov bot commented Nov 6, 2018 •
edited
Loading

Codecov Report

Merging #22888 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #22888      +/-   ##
==========================================
+ Coverage   92.25%   92.27%   +0.01%     
==========================================
  Files         161      161              
  Lines       51186    51186              
==========================================
+ Hits        47222    47230       +8     
+ Misses       3964     3956       -8
Flag Coverage Δ
#multiple 90.65% <ø> (+0.01%) ⬆️
#single 42.27% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/formats/html.py 93.16% <0%> (+2.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf6cd2...8d955ca. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Nov 7, 2018
@jreback jreback merged commit efeb2c5 into pandas-dev:master Nov 7, 2018
@jreback
Copy link
Contributor

jreback commented Nov 7, 2018

thanks!

@simonjayhawkins simonjayhawkins deleted the truncation-tests branch November 7, 2018 22:16
JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Nov 14, 2018
@simonjayhawkins @JustinZhengBC
TST: coverage for skipped tests in io/formats/test_to_html.py (pandas…
43b135f 
…-dev#22888)
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@simonjayhawkins @tm9k1
TST: coverage for skipped tests in io/formats/test_to_html.py (pandas…
2c2d675 
…-dev#22888)
@simonjayhawkins
Copy link
Member Author

xref #11060

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@simonjayhawkins @Pingviinituutti
TST: coverage for skipped tests in io/formats/test_to_html.py (pandas…
3deaaf3 
…-dev#22888)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@simonjayhawkins @Pingviinituutti
TST: coverage for skipped tests in io/formats/test_to_html.py (pandas…
5c990d0 
…-dev#22888)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO HTML read_html, to_html, Styler.apply, Styler.applymap Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@simonjayhawkins @pep8speaks @jreback